fix: Warnings in UI tests - WPB-20579

WireNetwork/Sources/WireNetwork/APIs/Rest/AuthenticationAPI/AuthenticationAPIV0.swift

@@ -18,9 +18,9 @@
 
 import Foundation
 import WireFoundation
 
 class AuthenticationAPIV0: AuthenticationAPI, VersionedAPI {
 
     let networkService: any NetworkServiceProtocol
 
     init(networkService: any NetworkServiceProtocol) {
@@ -213,8 +213,7 @@
         let (data, response) = try await networkService.executeRequest(request)
 
         guard
-            let responseURL = response.url,
-            let responseHeaders = response.allHeaderFields as? [String: String]
+            response.allHeaderFields is [String: String]
         else {
             throw AuthenticationAPIError.invalidResponse
         }
@@ -239,7 +238,7 @@
             .withBody(body, contentType: .json)
             .build()
 
-        let (data, response) = try await networkService.executeRequest(request)
+        let (_, response) = try await networkService.executeRequest(request)
 
         guard
             let responseURL = response.url,
@@ -271,9 +270,9 @@
             .withBody(body, contentType: .json)
             .build()
 
-        let (data, response) = try await networkService.executeRequest(request)
+        let (_, _) = try await networkService.executeRequest(request)
 
-        try ResponseParser()
+        _ = ResponseParser()
             .success(code: .ok)
             .failure(code: .badRequest, label: "bad-request", error: AuthenticationAPIError.invalidEmail)
     }

WireNetwork/Sources/WireNetwork/Authentication/AuthenticationManager.swift

@@ -45,14 +45,14 @@ public actor AuthenticationManager: AuthenticationManagerProtocol {
 
     private var currentToken: CurrentToken?
     private let clientID: String?
-    private let cookieStorage: any CookieStorageProtocol
-    private let networkService: any NetworkServiceProtocol
+    private let cookieStorage: any CookieStorageProtocol & Sendable
+    private let networkService: any NetworkServiceProtocol & Sendable
     private let onAuthenticationFailure: () -> Void
 
     public init(
         clientID: String?,
-        cookieStorage: any CookieStorageProtocol,
-        networkService: any NetworkServiceProtocol,
+        cookieStorage: any CookieStorageProtocol & Sendable,
+        networkService: any NetworkServiceProtocol & Sendable,
         onAuthenticationFailure: @escaping () -> Void
     ) {
         self.clientID = clientID
@@ -142,7 +142,7 @@ public actor AuthenticationManager: AuthenticationManagerProtocol {
     private func makeRenewTokenTask(
         lastKnownToken: AccessToken?
     ) -> Task<AccessToken, any Error> {
-        Task {
+        Task { @Sendable [cookieStorage, networkService, clientID] in
             let cookies = try await cookieStorage.fetchCookies()
 
             var requestBuilder = try URLRequestBuilder(path: "/access")

WireNetwork/Sources/WireNetwork/Network/NetworkStack/NetworkStack.swift

@@ -68,11 +68,8 @@ public actor NetworkStack {
                 proxyCredentials: proxyCredentials
             )
             self.state = .ready(services)
-        } catch .proxyCredentialsRequired {
-            self.state = .awaitingProxyCredentials
         } catch {
-            // Xcode warns that this case will never be executed, but if
-            // we take it away, it complains that not all errors are handled.
+            self.state = .awaitingProxyCredentials
         }
     }
 

wire-ios/WireUITests/Helper/UserHelper.swift

@@ -81,7 +81,7 @@ class UserHelper {
             email: user.email,
             password: user.password
         )
-        cookieStorage.cookies = cookies
+        try await cookieStorage.storeCookies(cookies)
 
         // Get activation code
         let (activationCode, activationKey) = try await authenticationAPI.getActivationCode(
@@ -306,8 +306,8 @@ enum FilterConversationsByCriteria {
     case conversationType(ConversationType?)
 }
 
-private final class MockCookieStorage: CookieStorageProtocol {
-    var cookies: [HTTPCookie]
+private actor MockCookieStorage: CookieStorageProtocol {
+    private var cookies: [HTTPCookie]
 
     init() {
         self.cookies = []