Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


StoryWPB-20714 [iOS] Upload asset with additional metadata

Issue

In this PR we include additional metadata when uploading assets if the asset audit log feature is enabled.

Changes include:

  • adjust api for appending image messages to accept a SendableImage rather than Data. This allow us to include additional metadata about the image such as the name and utType (which we'll upload)
  • unpack the necessary metadata and include it in the multipart data when uploading assets
  • only upload this data under certain conditions (feature is enabled, not connected to cloud backend)
  • delete dead code

Testing

  1. Connect to backend that has asset audit log enabled
  2. Send various asset messages (image, audio, video, file)
  3. Observe the network via a proxy (e.g Proxyman) and check the upload contains the metadata in the raw body.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some merge conflicts to resolve here

Copy link
Contributor Author

Test Results

7 122 tests   7 095 ✅  8m 44s ⏱️
  858 suites     27 💤
    6 files        0 ❌

Results for commit 26e617f.

@johnxnguyen johnxnguyen enabled auto-merge October 15, 2025 07:57
@johnxnguyen johnxnguyen added this pull request to the merge queue Oct 15, 2025
Merged via the queue into develop with commit 14bd9e3 Oct 15, 2025
14 checks passed
@johnxnguyen johnxnguyen deleted the feat/asset-audit-log-metadata-wpb-20714-cherry-pick branch October 15, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants