Skip to content

Standardize deployment features #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Veki301 merged 24 commits into from
Dec 17, 2025
Merged

Standardize deployment features #824

Veki301 merged 24 commits into from
Dec 17, 2025

Conversation

@Veki301
Copy link
Contributor

@Veki301 Veki301 commented Nov 14, 2025 •
edited
Loading

Change type

  • Fix
  • Feature
  • Documentation
  • Security / Upgrade

Basic information

  • THIS CHANGE REQUIRES A DEPLOYMENT PACKAGE RELEASE
  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE

Testing

  • I ran/applied the changes myself, in a test environment.
  • The CI job attached to this repo will test it for me.

Tracking

  • I added a new entry in an appropriate subdirectory of changelog.d
  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Knowledge Transfer

  • An Asciinema session is attached to the Jira ticket.

Motivation

Objective

Reason

Use case

@Veki301 Veki301 requested review from a team and julialongtin as code owners November 14, 2025 14:19
@sghosh23
Copy link
Contributor

sghosh23 commented Nov 17, 2025

Since you are also updating values file, please consider changing the rabbitmq-external credentials with guest:guest
While I was testing with BE version 5.23 cannon also needs rabbitmq-external, please configure that too.

@Veki301 Veki301 force-pushed the standardize-deployment-features branch from 49e65cf to 3afb179 Compare November 25, 2025 22:53
sghosh23
sghosh23 requested changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@sghosh23 sghosh23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just have couple of suggestions. Let me know if you need more clarifications.

@Veki301 Veki301 force-pushed the standardize-deployment-features branch from c48afa2 to 6f7b3ac Compare December 12, 2025 14:09
@Veki301 Veki301 force-pushed the standardize-deployment-features branch from 4672cae to 41a36d2 Compare December 16, 2025 14:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Veki301 Veki301 merged commit c99cdfc into master Dec 17, 2025
14 checks passed
@Veki301 Veki301 deleted the standardize-deployment-features branch December 17, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sghosh23 sghosh23 sghosh23 approved these changes

@julialongtin julialongtin Awaiting requested review from julialongtin julialongtin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Veki301 @sghosh23