Skip to content

Wpb 23988 enable 5.25#879

Open
mohitrajain wants to merge 10 commits intofix-wiab-stag-feedbackfrom
wpb-23988-enable-5.25
Open

Wpb 23988 enable 5.25#879
mohitrajain wants to merge 10 commits intofix-wiab-stag-feedbackfrom
wpb-23988-enable-5.25

Conversation

@mohitrajain
Copy link
Contributor

@mohitrajain mohitrajain commented Mar 12, 2026

Change type

  • Fix
  • Feature
  • Documentation
  • Security / Upgrade

Basic information

  • THIS CHANGE REQUIRES A DEPLOYMENT PACKAGE RELEASE
  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE

Testing

  • I ran/applied the changes myself, in a test environment.
  • The CI job attached to this repo will test it for me.

Offline Build CI (label-based)

Add one or more labels to trigger offline builds:

  • build-default - Full production build (ansible, terraform, all packages)
  • build-demo - Demo/WIAB build
  • build-wiab-staging - WIAB-staging build
  • build-min - Minimal build (fastest, essential charts only)
  • build-all - Run all three builds

Note: No builds run by default. Add a label to trigger CI.

Tracking

  • I added a new entry in an appropriate subdirectory of changelog.d
  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Knowledge Transfer

  • An Asciinema session is attached to the Jira ticket.

Motivation

Objective

Reason

Use case

@mohitrajain mohitrajain requested review from a team and julialongtin as code owners March 12, 2026 14:21
ansible_ssh_private_key_file: "~/.ssh/id_ed25519"
vars:
artifact_hash: 82edf88d9193e9f7e0a62ee4b287fd0c7cebb1bd
artifact_hash: 2200257f7a528f3a8157e8878fc7ee1c945594d1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it auto-generated or hardcoded hash?

Copy link
Contributor Author

@mohitrajain mohitrajain Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not auto populated as of now, we update it during releases and we have a ticket to automate in our backlog

background-worker:
secrets:
pgPassword: "{{ pgpassword }}"
when: "'postgresql' in charts_to_deploy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not it be version specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background-worker secret will be available from release-5.25
postresql chart and other charts are enabled via the inventory, https://github.com/wireapp/wire-server-deploy/blob/master/ansible/inventory/demo/host.yml#L53

This is dev environment, a user breaking it is expected

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What i mean here is this conditional block when: "'postgresql' in charts_to_deploy" it seems it checks in the postgresql is available in the charts_to_deploy. My point is this logic seems a bit off what does the charts-to-deploy contain? As we know pg has been introduced with version 5.16.0. So a version check of wire-server would be more sensible here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are managing this list for the dev testers at https://github.com/wireapp/wire-server-deploy/blob/master/ansible/inventory/demo/host.yml#L53 and our cd_demo.sh would fail if postgresql is required but is not present in the charts. This part of code is to be able to deploy older versions of wiab-dev without changing the code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a different list where pg is not required?

Copy link
Contributor Author

@mohitrajain mohitrajain Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, following releases (<5.16) don't have postgresql:
https://github.com/wireapp/wire-server-deploy/blob/wiab-514/ansible/inventory/demo/host.yml#L53
https://github.com/wireapp/wire-server-deploy/blob/min-release-q2-2025/ansible/inventory/demo/host.yml#L48

If there are more wiab-dev releases for <5.16, postgresql won't be part of any of those releases

username: elastic
password: changeme
username: "elastic"
password: "changeme"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a reference of the elasticsearch secrets which does not show password value is quoted. May be its better to align with this. Another question, do we need this secret here at all(we dont have any secret for cassandra, may be its different in k8s native)? In the recent version of 5.28 wire-server introduced postgresql in the index chart, we will be needing to adjust pgPassword here but that's later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry i didn't follow, is having a quote somehow updates the actual value which the pod receives?
This password aligns with its upstream chart - https://github.com/wireapp/wire-server/blob/develop/charts/elasticsearch-ephemeral/values.yaml#L22 if chart is running with Auth, we need to enable clients as well.

For pgPassword change in 5.28, I need to check the release logs. This PR is only for 5.25 as of now, we can update it when we release 5.28

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

region: "eu-west-1"
s3Bucket: assets
s3Endpoint: http://fake-aws-s3:9000
s3Endpoint: http://minio-external:9000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does demo uses minio-external?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it doesn't let me fix it

@sonarqubecloud
Copy link

# tag: some-tag (only override if you want a newer/different version than what is in the chart)
config:
redis:
host: databases-ephemeral-redis-ephemeral # Updated hostname for redis-ephemeral chart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
host: databases-ephemeral-redis-ephemeral # Updated hostname for redis-ephemeral chart
host: databases-ephemeral-redis-ephemeral # Updated hostname as per your env, check the redis service name in the k8s cluster `d kubectl get svc -A | grep redis`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can go better in the documentation as wiab-dev would get verified in cd_demo.sh first and then would be available in release. This service name would depend on the redis-ephemeral version getting shipped so there are high chances that we identify it and fix it per release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants