Wpb 23988 disable smallstep#882
Wpb 23988 disable smallstep#882mohitrajain wants to merge 2 commits intowpb-23988-fix-internet-access-wiab-stagfrom
Conversation
|
There was a problem hiding this comment.
Pull request overview
Disables deployment of the smallstep-accomp Helm chart in WIAB-related flows, aligning deployment automation and WIAB staging documentation with the intent to no longer include smallstep in those environments.
Changes:
- Remove
smallstep-accompfrombin/helm-operations.shchart processing and deployment order. - Update WIAB staging documentation to no longer list or link
smallstep-accomp. - Remove
smallstep-accompfrom the demo Ansible inventory chart deployment list. - Add a changelog entry documenting the change.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| offline/wiab-staging.md | Updates WIAB staging docs to exclude smallstep-accomp from deployed charts and further-reading links. |
| bin/helm-operations.sh | Stops preparing values for and deploying the smallstep-accomp chart. |
| ansible/inventory/demo/host.yml | Removes smallstep-accomp from charts_to_deploy. |
| changelog.d/3-deploy-builds/disable-smallstep | Adds release note about disabling smallstep deployments in WIAB environments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -194,7 +194,7 @@ d sh -c 'TARGET_SYSTEM="example.dev" CERT_MASTER_EMAIL="certmaster@example.dev" | |||
|
|
|||
| **Charts deployed by the script:** | |||
| - External datastores and helpers: `cassandra-external`, `elasticsearch-external`, `minio-external`, `rabbitmq-external`,`postgresql-external`, `databases-ephemeral`, `reaper`, `fake-aws`, `demo-smtp`. | |||
There was a problem hiding this comment.
The chart list still mentions demo-smtp, but this repo’s values and deployment automation use the smtp chart name (e.g., values/smtp/ and bin/helm-operations.sh deploys smtp). This can mislead WIAB staging users into looking for a non-existent demo-smtp chart in the bundle; consider updating this entry to smtp (or clarifying when demo-smtp applies).
| - External datastores and helpers: `cassandra-external`, `elasticsearch-external`, `minio-external`, `rabbitmq-external`,`postgresql-external`, `databases-ephemeral`, `reaper`, `fake-aws`, `demo-smtp`. | |
| - External datastores and helpers: `cassandra-external`, `elasticsearch-external`, `minio-external`, `rabbitmq-external`,`postgresql-external`, `databases-ephemeral`, `reaper`, `fake-aws`, `smtp`. |



Change type
Basic information
Testing
Offline Build CI (label-based)
Add one or more labels to trigger offline builds:
build-default- Full production build (ansible, terraform, all packages)build-demo- Demo/WIAB buildbuild-wiab-staging- WIAB-staging buildbuild-min- Minimal build (fastest, essential charts only)build-all- Run all three buildsNote: No builds run by default. Add a label to trigger CI.
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case