Skip to content

Wpb 23988 disable smallstep#882

Open
mohitrajain wants to merge 2 commits intowpb-23988-fix-internet-access-wiab-stagfrom
wpb-23988-disable-smallstep
Open

Wpb 23988 disable smallstep#882
mohitrajain wants to merge 2 commits intowpb-23988-fix-internet-access-wiab-stagfrom
wpb-23988-disable-smallstep

Conversation

@mohitrajain
Copy link
Contributor

@mohitrajain mohitrajain commented Mar 18, 2026

Change type

  • Fix
  • Feature
  • Documentation
  • Security / Upgrade

Basic information

  • THIS CHANGE REQUIRES A DEPLOYMENT PACKAGE RELEASE
  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE

Testing

  • I ran/applied the changes myself, in a test environment.
  • The CI job attached to this repo will test it for me.

Offline Build CI (label-based)

Add one or more labels to trigger offline builds:

  • build-default - Full production build (ansible, terraform, all packages)
  • build-demo - Demo/WIAB build
  • build-wiab-staging - WIAB-staging build
  • build-min - Minimal build (fastest, essential charts only)
  • build-all - Run all three builds

Note: No builds run by default. Add a label to trigger CI.

Tracking

  • I added a new entry in an appropriate subdirectory of changelog.d
  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Knowledge Transfer

  • An Asciinema session is attached to the Jira ticket.

Motivation

Objective

Reason

Use case

@sonarqubecloud
Copy link

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables deployment of the smallstep-accomp Helm chart in WIAB-related flows, aligning deployment automation and WIAB staging documentation with the intent to no longer include smallstep in those environments.

Changes:

  • Remove smallstep-accomp from bin/helm-operations.sh chart processing and deployment order.
  • Update WIAB staging documentation to no longer list or link smallstep-accomp.
  • Remove smallstep-accomp from the demo Ansible inventory chart deployment list.
  • Add a changelog entry documenting the change.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
offline/wiab-staging.md Updates WIAB staging docs to exclude smallstep-accomp from deployed charts and further-reading links.
bin/helm-operations.sh Stops preparing values for and deploying the smallstep-accomp chart.
ansible/inventory/demo/host.yml Removes smallstep-accomp from charts_to_deploy.
changelog.d/3-deploy-builds/disable-smallstep Adds release note about disabling smallstep deployments in WIAB environments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -194,7 +194,7 @@ d sh -c 'TARGET_SYSTEM="example.dev" CERT_MASTER_EMAIL="certmaster@example.dev"

**Charts deployed by the script:**
- External datastores and helpers: `cassandra-external`, `elasticsearch-external`, `minio-external`, `rabbitmq-external`,`postgresql-external`, `databases-ephemeral`, `reaper`, `fake-aws`, `demo-smtp`.
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart list still mentions demo-smtp, but this repo’s values and deployment automation use the smtp chart name (e.g., values/smtp/ and bin/helm-operations.sh deploys smtp). This can mislead WIAB staging users into looking for a non-existent demo-smtp chart in the bundle; consider updating this entry to smtp (or clarifying when demo-smtp applies).

Suggested change
- External datastores and helpers: `cassandra-external`, `elasticsearch-external`, `minio-external`, `rabbitmq-external`,`postgresql-external`, `databases-ephemeral`, `reaper`, `fake-aws`, `demo-smtp`.
- External datastores and helpers: `cassandra-external`, `elasticsearch-external`, `minio-external`, `rabbitmq-external`,`postgresql-external`, `databases-ephemeral`, `reaper`, `fake-aws`, `smtp`.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants