Skip to content

Wpb 20733 federation calling docs #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Wpb 20733 federation calling docs #4796

wants to merge 2 commits into from

Conversation

Veki301
Copy link
Contributor

@Veki301 Veki301 commented Sep 30, 2025

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@Veki301 Veki301 requested review from a team as code owners September 30, 2025 14:15
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 30, 2025
julialongtin
julialongtin requested changes Oct 2, 2025
View reviewed changes
charts/nginz/templates/conf/_nginx.conf.tpl
zauth_acl {{ .Values.nginx_conf.zauth_acl }};
oauth_pub_key {{ .Values.nginx_conf.oauth_pub_key }};

# bypass wire-server-enterprise requirement for new login UI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should no longer be necessary, and shouldn't be in this PR.

docs/src/understand/configure-federation.md
- turn secret from `brig`

```yaml
allowOrigin: "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign of a defect!

docs/src/understand/configure-federation.md

```yaml
envVars:
CSP_EXTRA_CONNECT_SRC: "https:*.example.org, wss://*.example.org"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also a sign of a defect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialongtin julialongtin julialongtin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Veki301 @julialongtin @zebot