WPB-20728 background job for user group to channel association #4797
Conversation
zebot
added
the
ok-to-test
battermann
force-pushed
the
WPB-20728-background-job-for-user-group-to-channel-association
branch
from
ff76698 to
7d72068
Compare
battermann
changed the base branch from
develop
to
gdifolco/WPB-19713_user-groups-channels-list
blackheaven
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
from
c71074e to
b4af1e1
Compare
blackheaven
force-pushed
the
WPB-20728-background-job-for-user-group-to-channel-association
branch
from
7d72068 to
a09bc11
Compare
| # Maximum number of in-flight jobs per process | ||
| concurrency: 8 | ||
| # Per-attempt timeout in seconds | ||
| jobTimeout: 60 |
There was a problem hiding this comment.
isn't this something we want to define per job type? deleting users takes less time than scanning a huge table for inconsistencies.
i have little context, though. maybe i'm thinking ahead to far.
| -- You should have received a copy of the GNU Affero General Public License along | ||
| -- with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| module Wire.API.BackgroundJobs where |
There was a problem hiding this comment.
i know we're using wire-api for way more than our types containing rest api artefacts, but is this pushing it too far? this module is not used in any service other than background worker, and i think it shouldn't be. move to background-worker subsystem?
| import Wire.BackgroundJobsRunner.Interpreter (interpretBackgroundJobsRunner) | ||
| import Wire.BackgroundWorker.Env (AppT) | ||
|
|
||
| dispatchJob :: Job -> AppT IO (Either Text ()) |
There was a problem hiding this comment.
maybe something with more structure than Text for the errors?
|
@battermann I have pushed the new jobs from the interpreter, I have fixed the job processing, and injected the options on the Haskell side. Tests and k8s are left to be done. Not touched: Matthias review and |
battermann
force-pushed
the
WPB-20728-background-job-for-user-group-to-channel-association
branch
from
58ad87b to
e967a41
Compare
Checklist
changelog.d