test(e2e): implement account settings regression tests [WPB-19935] #19540

xdubx · 2025-09-19T08:28:32Z

WPB-19935 [Web/QA] Write the account settings regression tests in Playwright

Description

Checklist

mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
PR has been self reviewed by the author;
Hard-to-understand areas of the code have been commented;
If it is a core feature, unit tests have been added;

codecov · 2025-09-19T09:24:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.65%. Comparing base (35ce2e5) to head (f9ab8ce).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #19540      +/-   ##
==========================================
- Coverage   43.66%   43.65%   -0.01%     
==========================================
  Files        1294     1294              
  Lines       32318    32318              
  Branches     7177     7177              
==========================================
- Hits        14111    14110       -1     
  Misses      16515    16515              
- Partials     1692     1693       +1

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…lication

github-actions · 2025-09-23T12:25:31Z

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

✅ Passed: 8
❌ Failed: 5
⏭ Skipped: 0
🔁 Flaky: 1
📊 Total: 14
⏱ Total Runtime: 892.4s (~ 14 min 52 sec)

Failed Tests:

❌ Calls in channels with device switch and screenshare (tags: TC-8754, crit-flow-web)

Location: specs/CriticalFlow/channelsCall-TC-8755.spec.ts:38
Duration: 36576ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="go-next"]')


   at pageManager/webapp/pages/groupCreation.page.ts:49

  47 |
  48 |   async clickNextButton() {
> 49 |     await this.nextButton.click();
     |                           ^
  50 |   }
  51 |
  52 |   async clickCreateGroupButton() {
    at GroupCreationPage.clickNextButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/groupCreation.page.ts:49:27)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:88:40
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:85:5

❌ Channels Management (tags: TC-8752, crit-flow-web)

Location: specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:36
Duration: 42625ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="go-next"]')


   at pageManager/webapp/pages/groupCreation.page.ts:49

  47 |
  48 |   async clickNextButton() {
> 49 |     await this.nextButton.click();
     |                           ^
  50 |   }
  51 |
  52 |   async clickCreateGroupButton() {
    at GroupCreationPage.clickNextButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/groupCreation.page.ts:49:27)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:72:33
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:69:3

❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)

Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37
Duration: 25279ms

Errors:

Error: expect(received).toBeFalsy()

Received: true

  125 |     await test.step('Member unmutes themselves', async () => {
  126 |       await memberCalling.unmuteSelfInFullScreen();
> 127 |       expect(await memberCalling.isSelfUserMutedInFullScreen()).toBeFalsy();
      |                                                                 ^
  128 |     });
  129 |
  130 |     await test.step('Validation: Owner sees member is unmuted', async () => {
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:127:65
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:125:5

❌ Group Video call (tags: TC-8637, crit-flow-web)

Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39
Duration: 52809ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="item-call"]').locator('[data-uie-name="do-call-controls-call-accept"]')


   at pageManager/webapp/pages/calling.page.ts:66

  64 |
  65 |   async clickAcceptCallButton() {
> 66 |     await this.acceptCallButton.click();
     |                                 ^
  67 |   }
  68 |
  69 |   async clickToggleVideoButton() {
    at CallingPage.clickAcceptCallButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/calling.page.ts:66:33)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:147:34
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:145:16

❌ Messages in Channels (tags: TC-8753, crit-flow-web)

Location: specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:44
Duration: 36107ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="go-next"]')


   at pageManager/webapp/pages/groupCreation.page.ts:49

  47 |
  48 |   async clickNextButton() {
> 49 |     await this.nextButton.click();
     |                           ^
  50 |   }
  51 |
  52 |   async clickCreateGroupButton() {
    at GroupCreationPage.clickNextButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/groupCreation.page.ts:49:27)
    at setupOwner (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:78:42)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:89:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:71:5

Flaky Tests:

⚠️ Setting up new device with a backup (tags: TC-8634, crit-flow-web)

Location: specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:35

Attempt 1
Result: ❌ Failed
Duration: 39778ms

Errors:

Error: locator.waitFor: Test ended.
Call log:
  - waiting for locator('[data-uie-name="item-message"] .message-body:not(:has(p.text-foreground)):has(.text)').last() to be visible


   at pageManager/webapp/pages/conversation.page.ts:162

  160 |     if (waitForVisibility) {
  161 |       // Wait for the last message to be visible
> 162 |       await this.messages.last().waitFor({state: 'visible', timeout: 20_000});
      |                                  ^
  163 |     }
  164 |
  165 |     // Then get all matching elements
    at ConversationPage.isMessageVisible (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts:162:34)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:87:33
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:72:3

Attempt 2
Result: ✅ Passed
Duration: 42318ms

xdubx · 2025-09-23T14:17:23Z

for the code duplication. i wanna refactor all modals but the tests are failing so i cannot test it in this case.

xdubx · 2025-09-23T14:21:18Z

one note the vars:
SSO_USERNAME
SSO_PASSWORD
SSO_EMAIL
need to be added to the action that run the tests.

e-maad

Well done 🚀
Added few comments, you can decide it you want to cater them in next PR or not cater at all.

playwright.config.ts

e-maad · 2025-09-23T14:46:00Z

test/e2e_tests/pageManager/webapp/modals/base.modal.ts

+  constructor(page: Page, modalLocator: string) {
+    this.page = page;
+    this.modal = page.locator(modalLocator);
+    this.modalTitle = this.modal.locator("[data-uie-name='status-modal-title']");


Maybe we can also replace these with getByTestId.

test/e2e_tests/pageManager/webapp/pages/account.page.ts

test/e2e_tests/utils/setup.utli.ts

test/e2e_tests/utils/userActions.ts

…egression-tests-in-playwright

iskvortsov

Added a few comments

iskvortsov · 2025-09-26T13:41:01Z

test/e2e_tests/pageManager/webapp/components/conversationSidebar.component.ts

    this.allConverationsButton = page.locator(`${selectByDataAttribute('go-recent-view')}`);
    this.connectButton = page.locator(`button${selectByDataAttribute('go-people')}`);
    this.archiveButton = page.locator(selectByDataAttribute('go-archive'));
+    this.manageTeamButton = page.locator(selectByDataAttribute('go-team-management'));


I doesn't make sense to have both getByTestId and selectByDataAttribute because they both locate elements by data-uie-name.

test/e2e_tests/pageManager/webapp/components/conversationSidebar.component.ts

iskvortsov · 2025-09-26T13:45:07Z

test/e2e_tests/pageManager/webapp/modals/error.modal.ts

+
+export class ErrorModal extends BaseModal {
+  constructor(page: Page) {
+    super(page, "[data-uie-name='primary-modals-container']");


I guess it doesn't make much sense since a lot of modals we have utilise the same [data-uie-name='primary-modals-container']. We either need to distinguish modals with some other means or add unique identifiers. @e-maad what do you think?

I agree with @iskvortsov, we should add unique identifiers.

…egression-tests-in-playwright

sonarqubecloud · 2025-10-08T11:23:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

xdubx added 4 commits September 11, 2025 13:42

wip

5b72548

wip

b53e99d

finish @TC-1948

68090bb

wip

2364a8d

otto-the-bot added type: test 👷 👕 size: XL labels Sep 19, 2025

xdubx requested a review from iskvortsov September 19, 2025 08:28

xdubx added 4 commits September 19, 2025 12:56

fix flakiness and create an base class for modals to prevent code dup…

0377118

…lication

fix selector to prevent double selection on id

071e02d

stable last test

18878c5

fix wrong classname and export setup app into setup file

7ef30fa

xdubx marked this pull request as ready for review September 23, 2025 12:24

xdubx requested review from a team and otto-the-bot as code owners September 23, 2025 12:24

xdubx force-pushed the WPB-19935-web-qa-write-the-account-settings-regression-tests-in-playwright branch from 1ba75cd to 7ef30fa Compare September 23, 2025 12:30

xdubx requested a review from thisisamir98 September 23, 2025 14:20

finish test suite

c5c7ad9

e-maad reviewed Sep 23, 2025

View reviewed changes

xdubx added 3 commits September 25, 2025 16:51

add suggestions

668efb8

Merge branch 'dev' into WPB-19935-web-qa-write-the-account-settings-r…

be378c0

…egression-tests-in-playwright

update to scim env vars

f341a92

iskvortsov reviewed Sep 26, 2025

View reviewed changes

Merge branch 'dev' into WPB-19935-web-qa-write-the-account-settings-r…

b56cddc

…egression-tests-in-playwright

xdubx enabled auto-merge (squash) September 26, 2025 14:28

xdubx added 2 commits October 1, 2025 10:11

Merge branch 'dev' into WPB-19935-web-qa-write-the-account-settings-r…

1712d20

…egression-tests-in-playwright

Merge branch 'dev' into WPB-19935-web-qa-write-the-account-settings-r…

931daa3

…egression-tests-in-playwright

otto-the-bot added 👕 size: L and removed 👕 size: XL labels Oct 7, 2025

xdubx added 4 commits October 7, 2025 10:41

fix imports

cd28d28

fix modals to previewed unnecessary fails

1d64f6d

fix data share detection

83b410e

Merge branch 'dev' into WPB-19935-web-qa-write-the-account-settings-r…

f9ab8ce

…egression-tests-in-playwright

test(e2e): implement account settings regression tests [WPB-19935] #19540

Are you sure you want to change the base?

test(e2e): implement account settings regression tests [WPB-19935] #19540

Uh oh!

Conversation

xdubx commented Sep 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

codecov bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Playwright Test Summary

Failed Tests:

Flaky Tests:

Uh oh!

xdubx commented Sep 23, 2025

Uh oh!

xdubx commented Sep 23, 2025

Uh oh!

e-maad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

e-maad Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iskvortsov left a comment

Choose a reason for hiding this comment

Uh oh!

iskvortsov Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iskvortsov Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

e-maad Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 8, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xdubx commented Sep 19, 2025 •

edited by github-actions bot

Loading

codecov bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 23, 2025 •

edited

Loading