Skip to content

fix: device deletion logout with wrong password #19633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: device deletion logout with wrong password #19633

wants to merge 2 commits into from

Conversation

arjita-mitra
Copy link
Contributor

Description

web-package PR

[Web] User gets logged out while trying to delete a device - using a wrong password

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@arjita-mitra arjita-mitra requested review from a team and otto-the-bot as code owners October 6, 2025 13:49
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • ✅ Passed: 0
  • ❌ Failed: 14
  • ⏭ Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 14
  • ⏱ Total Runtime: 873.5s (~ 14 min 34 sec)

Failed Tests:

❌ Account Management (tags: TC-8639, crit-flow-web)

Location: specs/CriticalFlow/accountManagement-TC-8639.spec.ts:37
Duration: 24231ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/accountManagement-TC-8639.spec.ts:67:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/accountManagement-TC-8639.spec.ts:64:3
❌ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow-web)

Location: specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:34
Duration: 25045ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:65:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:62:5
❌ Setting up new device with a backup (tags: TC-8634, crit-flow-web)

Location: specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:35
Duration: 23998ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:69:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:66:3
❌ Calls in channels with device switch and screenshare (tags: TC-8754, crit-flow-web)

Location: specs/CriticalFlow/channelsCall-TC-8755.spec.ts:38
Duration: 27964ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:74:11
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:70:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:69:5
❌ Channels Management (tags: TC-8752, crit-flow-web)

Location: specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:36
Duration: 27757ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:60:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:57:3
❌ Conversation Management (tags: TC-8636, crit-flow-web)

Location: specs/CriticalFlow/conversationManagement-TC-8636.spec.ts:33
Duration: 24089ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/conversationManagement-TC-8636.spec.ts:47:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/conversationManagement-TC-8636.spec.ts:44:3
❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)

Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37
Duration: 24394ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:73:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:70:5
❌ Group Video call (tags: TC-8637, crit-flow-web)

Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39
Duration: 25733ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:92:11
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:82:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:81:5
❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)

Location: specs/CriticalFlow/joinTeam-TC-8635.spec.ts:37
Duration: 25083ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:94:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:91:5
❌ Messages in 1:1 (tags: TC-8750, crit-flow-web)

Location: specs/CriticalFlow/messagesIn1On1-TC-8750.spec.ts:47
Duration: 26125ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesIn1On1-TC-8750.spec.ts:96:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesIn1On1-TC-8750.spec.ts:93:3
❌ Messages in Channels (tags: TC-8753, crit-flow-web)

Location: specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:44
Duration: 27658ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at setupMember (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:86:9)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:89:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:71:5
❌ Messages in Groups (tags: TC-8751, crit-flow-web)

Location: specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:42
Duration: 26477ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at setupUserA (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:68:9)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:81:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:64:5
❌ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)

Location: specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts:34
Duration: 24607ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts:74:11
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts:64:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts:63:5
❌ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)

Location: specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:31
Duration: 23281ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="primary-modals-container"][aria-label=\'Consent to share user data\']').locator('[data-uie-name="do-secondary"]')


   at pageManager/webapp/modals/dataShareConsent.modal.ts:63

  61 |   async clickDecline() {
  62 |     await this.declineButton.isVisible();
> 63 |     await this.declineButton.click();
     |                              ^
  64 |   }
  65 |
  66 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/modals/dataShareConsent.modal.ts:63:30)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:52:9
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:46:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:45:3

@arjita-mitra arjita-mitra changed the title Bugfix/device deletion logout fix: device deletion logout with wrong password Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

👕 size: XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arjita-mitra @otto-the-bot