-
Notifications
You must be signed in to change notification settings - Fork 295
chore(release): use git branch --format for clean contains check #19642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #19642 +/- ##
==========================================
- Coverage 43.64% 43.64% -0.01%
==========================================
Files 1294 1294
Lines 32343 32343
Branches 7183 7183
==========================================
- Hits 14117 14116 -1
Misses 16531 16531
- Partials 1695 1696 +1 🚀 New features to boost your workflow:
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
Failed Tests:❌ Calls in channels with device switch and screenshare (tags: TC-8754, crit-flow-web)Location: specs/CriticalFlow/channelsCall-TC-8755.spec.ts:38 Errors:
❌ Channels Management (tags: TC-8752, crit-flow-web)Location: specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:36 Errors:
❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37 Errors:
❌ Group Video call (tags: TC-8637, crit-flow-web)Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39 Errors:
❌ Messages in Channels (tags: TC-8753, crit-flow-web)Location: specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:44 Errors:
❌ Messages in Groups (tags: TC-8751, crit-flow-web)Location: specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:42 Errors:
Flaky Tests: |
Then we can close this PR in favor of yours. |
Description
it wrongly rejected valid commits because git branch --contains outputs a “*” on the current branch; now we use the formatted branch list (git branch --contains --format="%(refname:short)") so the containment check is clean and tagging no longer fails on commits that are actually on the branch.