-
Notifications
You must be signed in to change notification settings - Fork 296
ci(WPB-21987): shard playwright tests across multiple runners #19807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markbrockhoff
wants to merge
15
commits into
dev
Choose a base branch
from
ci/poc-shard-playwright-tests
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a131263
refactor: use nvmrc to select node version
markbrockhoff a31a393
feat: add job to build test service
markbrockhoff 0a0bdd6
feat: shard tests across multiple runners with integrated testservice…
markbrockhoff b09b647
fix: build shadowJar of testservice
markbrockhoff f44fd6e
fix: generate json report when merging blobs
markbrockhoff aca079c
refactor: only download chrome browser for tests
markbrockhoff a5226fc
ci: use github reporter in CI
markbrockhoff 6155afc
fix: re-use playwright config when merging reports to generate json r…
markbrockhoff 59f632a
refactor: don't pass github user and token when building testservice
markbrockhoff bbf4713
feat: use 16 runners for sharding
markbrockhoff 75fad0a
feat: execute regression tests in addition to critical flow
markbrockhoff f5e3c06
fix: make script for reporting playwright summary work with nested te…
markbrockhoff a0b1583
chore: use SHA for third party actions
markbrockhoff 62bfa16
refactor: use line reporter instead of github
markbrockhoff 6343db7
refactor: stop background process of testservice after test
markbrockhoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi: the only reason I pinned the actions version to a specific commit is because sonar was worried of a supply chain attack. Not sure what's better, having to manually update every time to get e.g. security patches or the risk of malicious code being merged into the action unnoticed.