Skip to content

Change RunDefaultContainerAndStopOnCleanup to use the interface testing.TB #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleg-nenashev merged 1 commit into from
May 4, 2025
Merged

Change RunDefaultContainerAndStopOnCleanup to use the interface testing.TB #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tc-wiremock-v3_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ func TestV3Auth(t *testing.T) {
}
}

func sendTestRequest(t *testing.T, req *http.Request) (int, string, error) {
func sendTestRequest(t testing.TB, req *http.Request) (int, string, error) {
t.Helper()

resp, err := http.DefaultClient.Do(req)
Expand Down
4 changes: 2 additions & 2 deletions tc-wiremock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomize
}

// Creates an instance of the WireMockContainer type that is automatically terminated upon test completion
func RunContainerAndStopOnCleanup(ctx context.Context, t *testing.T, opts ...testcontainers.ContainerCustomizer) (*WireMockContainer, error) {
func RunContainerAndStopOnCleanup(ctx context.Context, t testing.TB, opts ...testcontainers.ContainerCustomizer) (*WireMockContainer, error) {
container, err := RunContainer(ctx, opts...)
if err != nil {
t.Fatal(err)
Expand All @@ -84,7 +84,7 @@ func RunContainerAndStopOnCleanup(ctx context.Context, t *testing.T, opts ...tes
}

// Creates a default instance of the WireMockContainer type that is automatically terminated upon test completion
func RunDefaultContainerAndStopOnCleanup(ctx context.Context, t *testing.T) (*WireMockContainer, error) {
func RunDefaultContainerAndStopOnCleanup(ctx context.Context, t testing.TB) (*WireMockContainer, error) {
var emptyCustomizers []testcontainers.ContainerCustomizer
return RunContainerAndStopOnCleanup(ctx, t, emptyCustomizers...)
}
Expand Down