Major refactor #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Better naming conventions. - Extracted nested types. - Improved usability (currently mostly with static filters, specifically "transport" filters).
Changed Native.NdisApi visibility to internal. Changed multiple properties and methods to static as they did not access instance members. Updated .gitignore
… .NET single-file publishing. Fixed driver version reading not working when running a client as x86. Renamed FilterFields to StaticFilterFields and FilterFlags to FilterFields. Removed files of merged enums. Renamed files to match updated class names. Moved some classes to the NdisApiDotNet.Filters namespace. Moved constant and static read-only fields to new static class Consts. Renamed Native.NdisApi to Imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently contains:
To-do:
IPAddressand custom IPv4/6 types).This PR will be updated further while I'm working on my project utilizing this API.
Note: This PR currently uses my
.editorconfigrules (stuff like explicit type name overvar), if desired, once finalized I could revert some of those preference-driven changes.