fix(dev) Match client style modules precisely during CSS HMR - #17609
Open
thelazylamaGit wants to merge 3 commits into
Open
fix(dev) Match client style modules precisely during CSS HMR#17609thelazylamaGit wants to merge 3 commits into
thelazylamaGit wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: f07ba10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 416 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #17383 fixed stale server-rendered CSS during HMR, but its client-module detection included a broad same-file fallback intended to support speculative query variants such as
?usedand?direct.Those variants are not part of the verified Astro/Vite update path, and another style module associated with the same source file is not necessarily capable of applying the update. It could represent a different component style index or a non-injected CSS import.
This follow-up removes
hasClientStyleModuleByFile()and retains only the module matching behavior supported by observed requests and Astro’s CSS collection code.Changes
inlineparameter that Astro adds when loading component CSS text server-side..css?rawand.css?inlineimports on the SSR invalidation path because they export strings rather than injecting client styles.Testing
inlinecomponent requests mapping to their exact client equivalent.Docs
No docs changes. This tightens internal HMR module matching without changing public APIs.