Change incorrect type for jsFilesExtensions setting#115
Open
nip3o wants to merge 1 commit intowix-incubator:masterfrom
Open
Change incorrect type for jsFilesExtensions setting#115nip3o wants to merge 1 commit intowix-incubator:masterfrom
nip3o wants to merge 1 commit intowix-incubator:masterfrom
Conversation
nip3o
changed the title
RamyEl-basyouni
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation of type definitions in VSCode extensions is not very clear, but it seems like an array of types means "any of these types" rather than "an array with elements of this type". VSCode at least complains to setting this setting to its default value or to an array.
The same kind of definition is also used for the
experimentssetting, but i guess it works out anyway there since the only allowed type is an array.