Skip to content

Conversation

Idokah
Copy link
Contributor

@Idokah Idokah commented Mar 2, 2023

in managed-adapter PR this line:
const port = process.env.PORT || options?.port || 8080
will become
const port = options?.port || 8080

the process.env.PORT will be passed from main.ts and the relevant tests will pass the options object with the port,
didn't want to implement it in this PR to avoid too many conflicts, will implement it in managed-adapter

@Idokah Idokah requested a review from michaelir March 2, 2023 14:02
@reyou
Copy link

reyou commented Apr 19, 2024

Can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants