[wip] lianad: add store_transactions() command#1586
Open
pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
Open
[wip] lianad: add store_transactions() command#1586pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
Conversation
Collaborator
|
If we wish to import coins from a backup in future, I think this will need to be done as part of a fresh DB creation. This is because we'll need to populate the DB chain tip (height & hash) and coins before the poller starts running, in order to then handle updates to those imported coins in the usual way. As populating the coins during DB creation will also require the transactions to be populated, it may be better to import transactions during this DB creation rather than to an already-running lianad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this feature have been dropped from the backup/restore feature, putting it in a separate PR in case we want to import transactions in case of offline liana feature