Added tests for double get of a ref in C++ object#1112
Open
tdavidovicNV wants to merge 1 commit intowjakob:masterfrom
Open
Added tests for double get of a ref in C++ object#1112tdavidovicNV wants to merge 1 commit intowjakob:masterfrom
tdavidovicNV wants to merge 1 commit intowjakob:masterfrom
Conversation
wjakob
force-pushed
the
master
branch
3 times, most recently
from
4d71d9a to
238b695
Compare
wjakob
force-pushed
the
master
branch
4 times, most recently
from
477f67b to
75f7046
Compare
wjakob
force-pushed
the
master
branch
3 times, most recently
from
1235f9a to
4ba51fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR references a problem where an object of type
Outterthat holds a reference to an object of typeInner(both with intrusive pointers) triggers the doubleset_py_selferror when used like this:This is referenced in #1111