Conversation
like empty silkscreen
This reverts commit ed714cf.
b17179c to
adcb7ba
Compare
|
Hi! Thank you for doing this, I really do appreciate it. There's a lot of changes in this PR, and it would be easier to review if it were broken up into separate PRs - ideally one for each of those bullet points. I understand if that's more than you'd like to volunteer to do, and if that's the case I'll handle doing it myself once I have some more time. Also, more specifically I don't think the mirror option should default to true, since that changes existing behavior and all existing designs for use with Gingerbread would break. |
|
Hey! Of course, I can break it up into smaller pieces :) I will do it tomorrow. I also have a separate PR, that adds the ability to preview different copper finish colors. It crossed my mind that, for fun, I could migrate the project to TypeScript and develop a better development experience. What are your thoughts on this? |
|
Also, if you have other linter / formatter preferences, like Prettier, I could use that instead of Biome. |
|
I could've swore I had prettier setup here already, but I guess not lol.
Biome is fine.
Typescript would be welcome as well, I have a soft preference for esbuild
if not using TSC directly.
…On Sun, Dec 8, 2024, 11:35 AM Kristof Hauser ***@***.***> wrote:
Also, if you have other linter / formatter preferences, like Prettier, I
could use that instead of Biome.
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I42UIAEBGOFQYG7IQ432ERYONAVCNFSM6AAAAABTHARTMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWGIYTANJUGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Small things:
New features: