fix: Theme styles supersede default styles #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure theme styles supersede default styles.
Why?
Fix CMM-825.
When enabled, theme styles should take precedence over default styles.
Otherwise, it negates the "Apply theme styles" feature altogether.
How?
Relocate default global CSS variables so they are only loaded when theme
styles are disabled. Otherwise, due to the load order of stylesheets,
these default variables overrode theme style variables.
Testing Instructions
text.
Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast