Skip to content

ci(release): use get_prs_between_tags with fail_on_error #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mokagio merged 4 commits into from
Aug 27, 2026
Merged

ci(release): use get_prs_between_tags with fail_on_error #607

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc3a6d3
Bump release-toolkit to 15.0.0
mokagio Aug 27, 2026
ed6f7b9
Generate release notes via get_prs_between_tags
mokagio Aug 27, 2026
ae7c8ef
Streamline AI-generated comment
mokagio Aug 27, 2026
aea5c59
Remove a commented empty line
mokagio Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
source 'https://rubygems.org'

gem 'fastlane', '~> 2.238'
gem 'fastlane-plugin-wpmreleasetoolkit', '~> 14.11'
gem 'fastlane-plugin-wpmreleasetoolkit', '~> 15.0'
6 changes: 3 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ GEM
xcodeproj (>= 1.13.0, < 2.0.0)
xcpretty (~> 0.4.1)
xcpretty-travis-formatter (>= 0.0.3, < 2.0.0)
fastlane-plugin-wpmreleasetoolkit (14.11.3)
fastlane-plugin-wpmreleasetoolkit (15.0.0)
buildkit (~> 1.5)
chroma (= 0.2.0)
diffy (~> 3.3)
Expand Down Expand Up @@ -316,7 +316,7 @@ PLATFORMS

DEPENDENCIES
fastlane (~> 2.238)
fastlane-plugin-wpmreleasetoolkit (~> 14.11)
fastlane-plugin-wpmreleasetoolkit (~> 15.0)

CHECKSUMS
CFPropertyList (3.0.8) sha256=2c99d0d980536d3d7ab252f7bd59ac8be50fbdd1ff487c98c949bb66bb114261
Expand Down Expand Up @@ -358,7 +358,7 @@ CHECKSUMS
faraday-retry (2.4.0) sha256=7b79c48fb7e56526faf247b12d94a680071ff40c9fda7cf1ec1549439ad11ebe
fastimage (2.4.1) sha256=c64bebd46b6fd8943ab70c1e6e85ff728f970f2e48f92ecd249b6bc3a540ad20
fastlane (2.238.0) sha256=78e9252df2224c7e427012638e41051edfa29b133a40fda883fd2f1c13a77b98
fastlane-plugin-wpmreleasetoolkit (14.11.3) sha256=cfe39597775611aa7745ff3a6d6c7ac07644a052bee9d7e4c3eaebe0f7e03cac
fastlane-plugin-wpmreleasetoolkit (15.0.0) sha256=6ffd06713e7e98c0d4a65df404b6cf8ffe66258b0976900899d888e57909aa67
fastlane-sirp (1.1.0) sha256=10bc94f9682efd8e1badfb31452a76dd8981f1f3a33717c765fde6d75b54d847
fiddle (1.1.8) sha256=7fa8ee3627271497f3add5503acdbc3f40b32f610fc1cf49634f083ef3f32eee
forwardable (1.4.0) sha256=f1cd40cc9812937980e1c76f1aa053660990a7c9b6a98fc37d945468afcce838
Expand Down
12 changes: 7 additions & 5 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,14 +317,16 @@ end
# previous tag. `set_github_release`'s `is_generate_release_notes` cannot express
# one.
#
Comment thread
mokagio marked this conversation as resolved.
Outdated
# Uses `GithubHelper` rather than the `get_prs_between_tags` action that wraps it
# until https://github.com/wordpress-mobile/release-toolkit/pull/772 gets ships in the next release-toolkit
# version (at which point we'll be able to use the action and its new `fail_on_error: true` parameter)
# `fail_on_error` is required, not cosmetic: the tag is already pushed by this
# point, and the action otherwise returns the API error as the changelog itself,
# publishing a release whose notes read "❌ Error computing the list of PRs…".
Comment thread
mokagio marked this conversation as resolved.
Outdated
def generated_release_notes(version:, token:)
Fastlane::Helper::GithubHelper.new(github_token: token).generate_release_notes(
get_prs_between_tags(
repository: GITHUB_REPO,
tag_name: version,
previous_tag: previous_release_tag!(version: version, token: token)
previous_tag: previous_release_tag!(version: version, token: token),
fail_on_error: true,
Comment thread
mokagio marked this conversation as resolved.
github_token: token
)
end

Expand Down
Loading