Support media single fetch, upload, and delete using WordPress-rs #22036

adalpari · 2025-07-21T12:57:11Z

Description

This PR is migrating some of the media calls of our current XML-RPC flow.
Specifically, we are now allowing single media fetching, upload, and delete media.
All of these new flows are integrated with FluxC since is the common point from where all the UI calls are centralised. I have created a new MediaClient to easily isolate the new code from the FluxC module so it will make FluxC migration easier.

Testing instructions

Log into a self-hosted site with the regular credentials

Verify the Media list work, and you can upload and delete media as always.

Enable Application Password for that site or add a new one.

Verify you can browse media
Verify you can upload media
Verify you can delete media
Verify you can upload media directly when writing a post
Do other smoke tests with media

Screen.Recording.2025-07-21.at.16.40.58.mov

…ort-media-upload-and-delete-application-password

dangermattic · 2025-07-21T12:58:06Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2025-07-21T13:14:54Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22036-ab0ecb1
	Commit	`ab0ecb1`
	Direct Download	`wordpress-prototype-build-pr22036-ab0ecb1.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2025-07-21T13:15:19Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22036-ab0ecb1
	Commit	`ab0ecb1`
	Direct Download	`jetpack-prototype-build-pr22036-ab0ecb1.apk`

Note: Google Login is not supported on these builds.

codecov · 2025-07-21T14:16:33Z

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 39.02%. Comparing base (e5bf5b4) to head (ab0ecb1).
Report is 1 commits behind head on trunk.

Files with missing lines	Patch %	Lines
.../org/wordpress/android/fluxc/store/MediaStore.java	0.00%	6 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #22036   +/-   ##
=======================================
  Coverage   39.02%   39.02%           
=======================================
  Files        2153     2153           
  Lines      101494   101494           
  Branches    15585    15585           
=======================================
  Hits        39613    39613           
  Misses      58384    58384           
  Partials     3497     3497

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR migrates media operations (fetch, upload, delete) from XML-RPC to WordPress REST API using the WordPress-rs client for self-hosted sites with application passwords. The changes introduce a new REST API flow alongside existing XML-RPC and WordPress.com API flows.

Adds new MediaRSApiRestClient for WordPress REST API operations
Updates MediaStore to route self-hosted REST API requests to the new client
Implements fetch, upload, and delete functionality with proper error handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
MediaStore.java	Routes self-hosted REST API calls to new MediaRSApiRestClient
MediaRSApiRestClient.kt	Implements media operations using WordPress-rs with authentication and error handling

...c/src/main/java/org/wordpress/android/fluxc/network/rest/wpcom/media/MediaRSApiRestClient.kt

Copilot · 2025-07-21T14:41:40Z

...c/src/main/java/org/wordpress/android/fluxc/network/rest/wpcom/media/MediaRSApiRestClient.kt

+        dispatcher.dispatch(UploadActionBuilder.newUploadedMediaAction(payload))
+    }
+
+    private fun getWpApiClient(site: SiteModel): WpApiClient {


The getWpApiClient method creates a new WpApiClient instance on every call. Consider caching the client instance per site to avoid unnecessary object creation and potential connection overhead.

We don't want to cache the object because every call is associated with a specific site. Maybe we could create a map to store one client per site. I'm not sure that won't create other problems, though.
Anyway, we were advised that WpApiClient is supporting multiple instances and created to be used that way.

…ort-media-upload-and-delete-application-password

wpmobilebot · 2025-07-22T11:03:31Z

Project dependencies changes

list

! Upgraded Dependencies
rs.wordpress.api:android:trunk-0d7174336f381588dd577e60384225fa7b9f80c4, (changed from trunk-1ae11b4e897192f5064912d201e92539eb0b3416)
rs.wordpress.api:kotlin:trunk-0d7174336f381588dd577e60384225fa7b9f80c4, (changed from trunk-1ae11b4e897192f5064912d201e92539eb0b3416)

tree

 +--- project :libs:fluxc
-|    \--- rs.wordpress.api:android:trunk-1ae11b4e897192f5064912d201e92539eb0b3416
-|         +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-|         +--- net.java.dev.jna:jna:5.17.0
-|         +--- rs.wordpress.api:kotlin:trunk-1ae11b4e897192f5064912d201e92539eb0b3416
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
+|    \--- rs.wordpress.api:android:trunk-0d7174336f381588dd577e60384225fa7b9f80c4
+|         +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+|         +--- net.java.dev.jna:jna:5.17.0
+|         +--- rs.wordpress.api:kotlin:trunk-0d7174336f381588dd577e60384225fa7b9f80c4
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
-\--- rs.wordpress.api:android:trunk-1ae11b4e897192f5064912d201e92539eb0b3416 (*)
+\--- rs.wordpress.api:android:trunk-0d7174336f381588dd577e60384225fa7b9f80c4 (*)

nbradbury · 2025-07-22T11:17:37Z

...c/src/main/java/org/wordpress/android/fluxc/network/rest/wpcom/media/MediaRSApiRestClient.kt

+            val client = getWpApiClient(site)
+
+            val mediaResponse = client.request { requestBuilder ->
+                requestBuilder.media().retrieveWithEditContext(media.mediaId)


❓ This is for my own understanding: if we retrieve media with an edit context, does that mean that users without edit privilege will be unable to fetch media?

That's a good point. And probably @oguzkocer will better answer this question.

Here is the context:
We are not differentiating between media access when requesting it in the client right now, so I opted to ask for the less restrictive media mode like iOS seems to be doing.

if we retrieve media with an edit context, does that mean that users without edit privilege will be unable to fetch media?

That's correct. I think we shouldn't even show the Media page if the user doesn't have these permissions. Best way to go about this is probably to check how wp-admin looks/works for a user with subscriber role.

…lete-application-password

sonarqubecloud · 2025-07-22T11:40:25Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nbradbury

Looks good, nice work!

adalpari added 14 commits July 17, 2025 11:46

Adding fetch media

8445b8b

Handling media error

6b557c8

Adding delete media

bfdc3a1

Fix refactor

5f96a15

Uploading media

37161bd

Adding debug logs

30102ed

minor refactor

7d2c000

Merge remote-tracking branch 'origin/trunk' into feature/CMM-577-supp…

4506728

…ort-media-upload-and-delete-application-password

Extracting client build code

1ae686f

Fixing completion issue

b750ed8

Adding the cancellation function

3b36e77

Some cleaning

a6f9098

detekt

0f8ff1e

Reverting cancellation

387746f

Removing unused function

40301ce

adalpari requested a review from Copilot July 21, 2025 14:40

Copilot AI reviewed Jul 21, 2025

View reviewed changes

adalpari added 3 commits July 21, 2025 16:45

Copilot suggestions

dca3f95

Merge remote-tracking branch 'origin/trunk' into feature/CMM-577-supp…

03c39c4

…ort-media-upload-and-delete-application-password

Updating wordpress-rs and minor fox

8ccbbc2

adalpari requested a review from nbradbury July 22, 2025 11:04

adalpari marked this pull request as ready for review July 22, 2025 11:04

adalpari requested a review from a team as a code owner July 22, 2025 11:04

adalpari added the [Type] Task label Jul 22, 2025

nbradbury self-assigned this Jul 22, 2025

nbradbury reviewed Jul 22, 2025

View reviewed changes

Merge branch 'trunk' into feature/CMM-577-support-media-upload-and-de…

ab0ecb1

…lete-application-password

nbradbury approved these changes Jul 22, 2025

View reviewed changes

adalpari merged commit 301bbc8 into trunk Jul 22, 2025
30 of 32 checks passed

adalpari deleted the feature/CMM-577-support-media-upload-and-delete-application-password branch July 22, 2025 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support media single fetch, upload, and delete using WordPress-rs #22036

Support media single fetch, upload, and delete using WordPress-rs #22036

Uh oh!

adalpari commented Jul 21, 2025 •

edited by nbradbury

Loading

Uh oh!

dangermattic commented Jul 21, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 21, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 21, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 21, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 21, 2025

Uh oh!

adalpari Jul 21, 2025

Uh oh!

wpmobilebot commented Jul 22, 2025

Uh oh!

nbradbury Jul 22, 2025

Uh oh!

adalpari Jul 22, 2025

Uh oh!

oguzkocer Jul 22, 2025

Uh oh!

sonarqubecloud bot commented Jul 22, 2025

Uh oh!

nbradbury left a comment

Uh oh!

Uh oh!

Uh oh!

Support media single fetch, upload, and delete using WordPress-rs #22036

Support media single fetch, upload, and delete using WordPress-rs #22036

Uh oh!

Conversation

adalpari commented Jul 21, 2025 • edited by nbradbury Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

dangermattic commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

adalpari Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Jul 22, 2025

Project dependencies changes

Uh oh!

nbradbury Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

adalpari Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

oguzkocer Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 22, 2025

Quality Gate passed

Uh oh!

nbradbury left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adalpari commented Jul 21, 2025 •

edited by nbradbury

Loading

dangermattic commented Jul 21, 2025 •

edited

Loading

wpmobilebot commented Jul 21, 2025 •

edited

Loading

wpmobilebot commented Jul 21, 2025 •

edited

Loading

codecov bot commented Jul 21, 2025 •

edited

Loading