Skip to content

fix: Remove redundant trailing slash from API namespace configuration #22065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025

Conversation

dcalhoun
Copy link
Member

Description

Update namespace configuration to match GutenbergKit's latest format, where trailing slashes are provided by the host app. Relates to wordpress-mobile/GutenbergKit#158.

Ref CMM-623.

Testing instructions

  1. Open a new post.
  2. Insert an image block.
  3. Choose an image to upload.
  4. Verify the upload succeeds.

@dcalhoun dcalhoun requested a review from a team as a code owner July 28, 2025 15:54
@dcalhoun dcalhoun requested review from nbradbury and removed request for a team July 28, 2025 15:54
@dcalhoun dcalhoun added [Type] Bug Gutenberg Editing and display of Gutenberg blocks. labels Jul 28, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 28, 2025

Project dependencies changes

list
! Upgraded Dependencies
org.wordpress.gutenbergkit:android:v0.6.0, (changed from v0.5.0)
tree
 +--- project :libs:editor
-|    \--- org.wordpress.gutenbergkit:android:v0.5.0
+|    \--- org.wordpress.gutenbergkit:android:v0.6.0
-\--- org.wordpress.gutenbergkit:android:v0.5.0 (*)
+\--- org.wordpress.gutenbergkit:android:v0.6.0 (*)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 28, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr22065-7227c35
Commit7227c35
Direct Downloadjetpack-prototype-build-pr22065-7227c35.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 28, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr22065-7227c35
Commit7227c35
Direct Downloadwordpress-prototype-build-pr22065-7227c35.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good :shipit:

Copy link

@dcalhoun dcalhoun enabled auto-merge (squash) July 28, 2025 20:06
@dcalhoun dcalhoun merged commit 910c91f into trunk Jul 28, 2025
26 checks passed
@dcalhoun dcalhoun deleted the fix/gutenberg-kit-api-namespace-configuration branch July 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants