feat: GutenbergKit supports mentions and cross-posts #22109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Enhancement
Gutenberg
Project dependencies changeslist! Upgraded Dependencies
org.wordpress.gutenbergkit:android:v0.8.0-alpha.0, (changed from v0.7.0)tree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:v0.7.0
+| \--- org.wordpress.gutenbergkit:android:v0.8.0-alpha.0
-\--- org.wordpress.gutenbergkit:android:v0.7.0 (*)
+\--- org.wordpress.gutenbergkit:android:v0.8.0-alpha.0 (*) |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22109-61b7b58 | |
| Commit | 61b7b58 | |
| Direct Download | wordpress-prototype-build-pr22109-61b7b58.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22109-61b7b58 | |
| Commit | 61b7b58 | |
| Direct Download | jetpack-prototype-build-pr22109-61b7b58.apk |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #22109 +/- ##
==========================================
+ Coverage 5.37% 39.43% +34.06%
==========================================
Files 10 2149 +2139
Lines 335 101872 +101537
Branches 45 15604 +15559
==========================================
+ Hits 18 40177 +40159
- Misses 317 58126 +57809
- Partials 0 3569 +3569 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR integrates GutenbergKit's autocompleter functionality to support @mentions and cross-post suggestions in the WordPress Android app. The implementation leverages GutenbergKit's onAutocompleterTriggered event and appendTextAtCursor method to provide a consistent autocomplete experience.
Key changes:
- Updated GutenbergKit dependency to a development branch version that includes the autocompleter features
- Implemented autocompleter listener in GutenbergKitEditorFragment to handle @mention and +cross-post triggers
- Added XPosts capability configuration that respects site permissions and user capabilities
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates GutenbergKit dependency to development branch version with autocompleter support |
| GutenbergKitEditorFragment.kt | Implements autocompleter functionality with listeners for mentions and cross-posts |
| EditPostActivity.kt | Configures XPosts capability based on site and user permissions |
WordPress/src/main/java/org/wordpress/android/ui/posts/editor/GutenbergKitEditorFragment.kt
Show resolved
Hide resolved
dcalhoun
force-pushed
the
feat/gutenberg-kit-mentions-and-cross-posts
branch
from
025812c to
06c7f02
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close CMM-455. Dependent upon wordpress-mobile/GutenbergKit#165.
Leverage GutenbergKit's
onAutocompleterTriggeredevent andappendTextAtCursormethod for displaying and inserting@mentionand+cross-postsuggestions.Testing instructions
Explore
@mentionand+cross-postautocompletion. Try inserting triggers at various locations to verify expected behavior:<line-start>@<cursor>@text<cursor>text@<cursor>text @<cursor>moretext more@<cursor>