Skip to content

Conversation

kean
Copy link
Contributor

@kean kean commented Sep 10, 2025

In the simplified implementation, you can tap or you can drag. You can on longer long-press.

Testing

  • Verify that you can still tap on a chart to show the selected period
  • Verify that you can drag horizontally to show the tooltips (long-press no longer works)

I'll do another pass on it when I have time, but I've spent a ton of time on it already. The new version prioritizes scrolling and tapping over annotations, which I assume is what most people would expect to work.

@kean kean added this to the 26.3 milestone Sep 10, 2025
@kean kean requested a review from crazytonyli September 10, 2025 20:31
@kean kean added the Stats label Sep 10, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean kean force-pushed the task/bar-chart-disable-vertical-gesture branch from 77b6899 to 5f5f386 Compare September 10, 2025 20:32
.simultaneousGesture(
DragGesture(minimumDistance: 0)
DragGesture(minimumDistance: 16)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting minimumDistance is what does the trick of allowing it to run alongside the scroll in a scroll view. Reference: https://darjeelingsteve.com/articles/Preventing-Scroll-Hijacking-by-DragGestureRecognizer-Inside-ScrollView.html.

Copy link

@kean kean enabled auto-merge September 10, 2025 20:35
@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number28894
VersionPR #24822
Bundle IDorg.wordpress.alpha
Commit5f5f386
Installation URL3kvalo1fo8p5o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number28894
VersionPR #24822
Bundle IDcom.jetpack.alpha
Commit5f5f386
Installation URL5hosc44matnto
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean added this pull request to the merge queue Sep 10, 2025
Merged via the queue into trunk with commit d6cdeb5 Sep 10, 2025
30 of 32 checks passed
@kean kean deleted the task/bar-chart-disable-vertical-gesture branch September 10, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants