Extract the table view in Blog Details to Swift #24974
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29707 | |
| Version | PR #24974 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b2b6494 | |
| Installation URL | 7gdjuk880pl80 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29707 | |
| Version | PR #24974 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b2b6494 | |
| Installation URL | 4a6mj9cirve0g |
|
Contributor
Author
|
This PR is now part of #24981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts the table view parts of the
BlogDetailsViewController(in Objective-C) to a Swift implementation.The majority of the changes are translated, without much of the swiftification. I made small improvements here and there, but not a lot.
I tried to group relevant changes into individual commits, but that turned out to be very difficult.
The
BlogDetailsViewControlleris now pretty small. The next step is turning the view controller to Swift.Testing instructions
The best way to test this change is to run the trunk branch and this branch on the iPad and iPhone simulators. Go to a WP.com site and a self-hosted site. You should not notice any difference in the blog details, which can be