Translate a few simple Core Data model types into Swift #24983
Conversation
crazytonyli
changed the title
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29771 | |
| Version | PR #24983 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 1f275c2 | |
| Installation URL | 0eg2pc1pqe4e0 |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29771 | |
| Version | PR #24983 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1f275c2 | |
| Installation URL | 545khcjihurho |
crazytonyli
force-pushed
the
core-data-model-to-swift
branch
from
14b925c to
2f647ff
Compare
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
This looks good to me – thanks for the clear commits – that make it a lot easier to review.
| return "Category" | ||
| } | ||
|
|
||
| @objc public static var uncategorizedId: NSNumber { |
There was a problem hiding this comment.
I'm not too sure about uncategorizedId but I understand why it works this way – doing PostCategory.uncategorized would imply that it's a PostCategory object not the default ID.
Probably not worth addressing?
There was a problem hiding this comment.
I have change the name in 1f275c2 to make it consistent with the original ObjC code: PostCategoryUncategorized(objc) -> PostCategory.uncategorized(swift)
| // MARK: - Constants | ||
|
|
||
| public let PostCategoryEntityName = "Category" | ||
| public let PostCategoryNameKey = "categoryName" |
There was a problem hiding this comment.
| // MARK: - Constants | |
| public let PostCategoryEntityName = "Category" | |
| public let PostCategoryNameKey = "categoryName" |
I don't see these referenced anywhere so I think they can be removed? None of the other classes have them.
|
|
||
| @interface PostCategory : NSManagedObject | ||
|
|
||
| @property (nonatomic, strong) NSNumber *categoryID; |
There was a problem hiding this comment.
This changed from optional to non-optional in this PR, but I validated that it's not optional in the Core Data model so the change is valid.
|
Description
Translate a few simple Core Data model types into Swift. I hope to eliminate Objective-C code in the WordPressData module, so that we have the option to move it to the SPM package.
It'd be easier to review this PR commit by commit.