Re-implement RemoteReaderPost in Swift - Part 1
#561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
reviewed
Dec 15, 2022
| @@ -0,0 +1,17 @@ | |||
| import Foundation | |||
There was a problem hiding this comment.
This import might be unnecessary.
There was a problem hiding this comment.
Yes, that's true for the current project setup. But I think it's needed for SPM support.
|
I've changed the base branch to the dedicated Swift migration branch, see #562 for more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RemoteReaderPosthas lots of parsing functions, it would be very hard to review and easy to make mistakes if translating the ObjC code to Swift in one go. I will break down the translation into a few parts. The first PR here translates the simpliest parsing functions, which are all covered by unit tests.Testing Details
We should be good if the CI jobs are green.
versionin the.podspecfile.