Skip to content

Adds install-node-dependencies command to Build JS Bundles #6736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Adds install-node-dependencies command to Build JS Bundles #6736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ steps:
# The following plugins are disabled temporarily until PHP is available.
# In the meantime, we'll keep using the GB-mobile docker container.
- *gb-mobile-docker-container
# - *ci_toolkit_plugin # unused?
- *ci_toolkit_plugin
# - *nvm_plugin
- *git-partial-clone-plugin
command: |
Expand All @@ -128,8 +128,7 @@ steps:
echo "--- :node: Set up Node environment"
nvm install && nvm use

echo "--- :npm: Install Node dependencies"
npm ci --unsafe-perm --prefer-offline --no-audit --no-progress
.buildkite/commands/install-node-dependencies.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mokagio 👋 I saw we weren't using the newly introduced install-node-dependencies.sh for the JS Bundle generation. Is it because we are using a docker container? I tried to add it but it failed 😅


if [[ -z "$BUILDKITE_TAG" ]]; then
echo "--- :package: Skip bundle prep work"
Expand Down