CI: replace broken Docker actions with ruby/setup-ruby#24
Open
kitcommerce wants to merge 1 commit intomasterfrom
Open
CI: replace broken Docker actions with ruby/setup-ruby#24kitcommerce wants to merge 1 commit intomasterfrom
kitcommerce wants to merge 1 commit intomasterfrom
Conversation
The workarea-commerce/ci/* Docker actions (bundler-audit@v1, rubocop@v1, eslint@v1, stylelint@v1, test@v1) are pinned to ruby:2.6 and use node12 runtime, both of which are deprecated and fail on modern GitHub runners. Changes: - Replace workarea-commerce/ci/bundler-audit@v1 with bundle exec bundler-audit - Replace workarea-commerce/ci/rubocop@v1 with bundle exec rubocop - Replace workarea-commerce/ci/eslint@v1 with yarn + eslint directly - Replace workarea-commerce/ci/stylelint@v1 with yarn + stylelint directly - Replace workarea-commerce/ci/test@v1 with native GH Actions services (MongoDB 4.4, Elasticsearch 5.6.16, Redis 6) + direct bin/rails commands - Add Ruby 2.7/3.2 matrix for test jobs - Use actions/checkout@v4 and ruby/setup-ruby@v1 - Add bundler-audit to Gemfile Closes workarea-commerce/workarea#724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken CI caused by deprecated
workarea-commerce/ci/*Docker actions. All of these actions are pinned toruby:2.6(EOL) and usenode12runner runtime (also deprecated), causing every CI run to fail.Changes
bundler-audit@v1andrubocop@v1withruby/setup-ruby@v1+ direct gem executioneslint@v1andstylelint@v1withactions/setup-node@v4+ yarn + direct CLI executiontest@v1with native GitHub Actions services (MongoDB 4.4, Elasticsearch 5.6.16, Redis 6) +bin/railsdirectlyactions/checkout@v4,ruby/setup-ruby@v1,actions/setup-node@v4bundler-auditgem (required for bundle exec bundler-audit)Part of
workarea-commerce/workarea#724 — fixing CI across all 31 plugin repos