Skip to content

[BUG]: Make sure hnsw_cache_size is never zero to avoid seg fault #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG]: Make sure hnsw_cache_size is never zero to avoid seg fault #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions chromadb/api/rust.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,8 @@ def __init__(self, system: System):
max_file_handles = resource.getrlimit(resource.RLIMIT_NOFILE)[0]
else:
max_file_handles = ctypes.windll.msvcrt._getmaxstdio() # type: ignore
self.hnsw_cache_size = (
max_file_handles
# This is integer division in Python 3, and not a comment.
# Each HNSW index has 4 data files and 1 metadata file
// 5
)
# Calculate cache size with a minimum value of 1 to avoid segmentation fault
self.hnsw_cache_size = max(1, max_file_handles // 5)

@override
def start(self) -> None:
Expand Down