Skip to content

Conversation

priyankc
Copy link
Member

@priyankc priyankc commented May 19, 2025

Description of changes

When a user runs chroma update from the command line, the code should detect this command and run the update() function to check for newer versions of Chroma. It is incorrectly checking for the command line arguments

Test plan

pip install -e .

python3 -c "import sys; from chromadb.cli import cli; sys.argv = ['chroma', 'update']; cli.app()"

  • Doesn't trigger chroma update. You will see a wrong message:
image
  • Run the above with fix, you will see update run correctly.
image
  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants