fix(datetime): strip whitespace from datetime strings #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where datetime strings with trailing spaces will cause an error when using the datetime expression in a formula query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where datetime strings with trailing spaces will cause an error when using the datetime expression in a formula query.
Fixes qdrant#985
Test Plan:
Created a script that writes to a local qdrant and correctly reproduced the bug.
Before the patch, it failed by correctly reproducing the bug:
After the patch, it works as expected:
Test Script for reference: https://gist.github.com/priyankc/9d8114b5aac5ae89241d78fb0488a782