Skip to content

Migration: univariate #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Migration: univariate #379

wants to merge 7 commits into from

Conversation

ethevenot
Copy link
Member

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

closes issue #332

bgruening
bgruening reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ethevenot!

Can the entire runit folder be removed? Please keep in mind that by default everything will be pushed into the TS and will endup on all Galaxy servers.

tools/univariate/.gitignore Outdated
@@ -0,0 +1,10 @@
runit/output/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a global gitignore file would be more useful.

tools/univariate/univariate_config.xml Outdated
Comment on lines 9 to 13
<stdio>
<exit_code range="1:" level="fatal" />
</stdio>

<command><![CDATA[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<stdio>
<exit_code range="1:" level="fatal" />
</stdio>
<command><![CDATA[
<command detect_errors="exit_code"><![CDATA[

See https://docs.galaxyproject.org/en/latest/dev/schema.html#error-detection

tools/univariate/univariate_config.xml Outdated
Comment on lines 20 to 23
facC "$facC"
tesC "$tesC"
adjC "$adjC"
thrN "$thrN"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
facC "$facC"
tesC "$tesC"
adjC "$adjC"
thrN "$thrN"
facC '$facC'
tesC '$tesC'
adjC '$adjC'
thrN '$thrN'

tools/univariate/univariate_config.xml Outdated
Comment on lines 25 to 27
variableMetadata_out "$variableMetadata_out"
figure "$figure"
information "$information"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single-quotes are needed here as well

@hechth hechth marked this pull request as draft July 16, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgruening bgruening bgruening left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethevenot @bgruening