Skip to content

Conversation

llegregam
Copy link
Contributor

@llegregam llegregam commented Jul 17, 2025

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Comment on lines +48 to +54
<param type='select' name='norm_type' label='Normalization type' help='Select the type of normalization to apply to fluxes'>
<option value='text'>Parameter Name</option>
<option value='float'>Custom Value</option>
</param>
<when value='text'>
<param type='text' name='norm_text' label='Parameter name' help='Name of the parameter to normalize fluxes by (e.g. glc_uptake)'/>
</when>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that only certain text values are supported, so I assume a select would be better suited here? Or is this supposed to be a column from a table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal here is to normalize all values by either a given value in the data which is referenced using the text option (containing the column entry with the value to normalize by) or use a user-supplied value in the form of a float.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I have no real idea why my test is not functionning, when I serve the tool locally it works but planemo test returns this error each time: Output collection 'list_output': failed to find identifier 'Sample_1' in the tool generated elements ['conda_activate.log']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants