Skip to content

WIP: expectAssertion updates for RFC 232 compat#21

Open
alexdiliberto wants to merge 3 commits intoworkmanw:async-wipfrom
alexdiliberto:async-wip
Open

WIP: expectAssertion updates for RFC 232 compat#21
alexdiliberto wants to merge 3 commits intoworkmanw:async-wipfrom
alexdiliberto:async-wip

Conversation

@alexdiliberto
Copy link
Copy Markdown

No description provided.

@alexdiliberto alexdiliberto changed the title WIP WIP: expectAssertion updates for RFC 232 compat Oct 25, 2017
@cibernox
Copy link
Copy Markdown
Contributor

I entered the repo looking for this. What is missing on this? May I help?

@rwjblue
Copy link
Copy Markdown
Collaborator

rwjblue commented Nov 14, 2017

@cibernox - Likely needs some "dusting off" and bug fixing (since CI is failing). I think the main changes to the expectAssertion functions are based on my wip here: master...async-wip. We'd love someone to tackle this and push it over the hump...

@alexdiliberto
Copy link
Copy Markdown
Author

@cibernox Hit a bit of a roadblock described here #18 (comment) and haven't had a chance to look at it again. Please work on it if you have some spare time, would love the help!

@cibernox
Copy link
Copy Markdown
Contributor

@alexdiliberto @rwjblue I've started by an update-only PR (#23) to separate the wheat from the chaff.

@shokmaster
Copy link
Copy Markdown

Hi guys! Any news about this issue? We're having problems with the function expectAssertion in our project. We're patching a setupExpectAssertion() based on #18 (comment) but it's a bit unestable in some scenarios.

Perhaps it would be convenient to update the async-wip branch with the @cibernox PR (#23) and separate the framework/CLI update from the adaptation to the RFC.

Let me know if I can help in any way. Thanks in advance!

@stefanpenner
Copy link
Copy Markdown
Collaborator

I am upstreaming these assertions into ember-qunit

I will review this PR, and try and incorporate appropriate changes upstream.

When all this lands, my plan is to deprecate this library entirely in-favor of it's assertions simply being officially supported: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants