fix(build): ember-auto-import@2 compatibility#30
Open
buschtoens wants to merge 1 commit intoworkmanw:masterfrom
Open
fix(build): ember-auto-import@2 compatibility#30buschtoens wants to merge 1 commit intoworkmanw:masterfrom
ember-auto-import@2 compatibility#30buschtoens wants to merge 1 commit intoworkmanw:masterfrom
Conversation
|
The other thing I'd recommend is dropping this auto-registration entirely and telling users to do this import themselves, from their test-setup.js file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes this addon compatible with
ember-auto-import@2host apps.Closes #25.
This is not the ideal solution, but the most trivial one.
As this addon is considered dormant and its features are set to be upstreamed into
ember-qunit, I don't expect the owner @workmanw to cut a new release. Instead affected users may usepatch-packageto apply this fix locally.