svelte/1: Add csp_nonce parameter#191
Open
xtian wants to merge 2 commits intowoutdp:masterfrom
Open
Conversation
xtian
force-pushed
the
csp-nonce
branch
2 times, most recently
from
0cd13ef to
b72fe17
Compare
Collaborator
|
@xtian Tests would be greatly appreciated |
timmywil
reviewed
Feb 28, 2026
| <script> | ||
| <script {@csp_script_attrs}> | ||
| <%= raw(@ssr_render["head"]) %> | ||
| </script> |
There was a problem hiding this comment.
@gevera Is it possible to remove this script tag? I'm not 100% on what @ssr_render contains, but @ssr_render["head"] is also rendered below in a div.
Collaborator
There was a problem hiding this comment.
I think yes. At the moment the priority is to backport LiveVue features to LiveSvelte (vite, igniter etc). Once that is finished, I am sure most of the issues opened will automatically be irrelevant. Might be this one as well. Will see.
Author
|
@gevera I updated with tests |
xtian
commented
Apr 12, 2026
| "import": "./assets/js/live_svelte/index.ts", | ||
| "types": "./assets/js/live_svelte/types.d.ts" | ||
| "types": "./assets/js/live_svelte/types.d.ts", | ||
| "import": "./assets/js/live_svelte/index.ts" |
Author
There was a problem hiding this comment.
I needed this change to fix type errors in my project
woutdp
force-pushed
the
master
branch
5 times, most recently
from
3c92d4e to
ec88a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates LiveSvelte.svelte/1 to accept a Content-Security-Policy nonce to add to the generated
<script>and<style>tags.Fixes #102