Update build.yaml to support build wheels for python 3.7 and Upgrade to sqlparser-rs 0.56.0 #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to statistics, Python 3.7's current usage share still exceeds 20%. Since sqloxide itself supports Python 3.7, we hope to ensure support for it when building wheels.
Notes:
In v0.55 of sqlparser-rs, the `ObjectName` structure has been changed as shown below. Here is now to migrate.
```diff
- pub struct ObjectName(pub Vec<Ident>);
+ pub struct ObjectName(pub Vec<ObjectNamePart>)
```
Therefore, when using the `parse_sql` function, the data structure of the table name in the return value will change.
Previously:
```json
{
"value": "employee",
"quote_style": null,
"span":
{
"start":
{
"line": 4,
"column": 10
},
"end":
{
"line": 4,
"column": 18
}
}
}
```
Now:
```json
{
"Identifier":
{
"value": "employee",
"quote_style": null,
"span":
{
"start":
{
"line": 4,
"column": 10
},
"end":
{
"line": 4,
"column": 18
}
}
}
}
```
vimko
changed the title
|
@wseaton review pls. |
|
Thanks, I will review today! |
|
@vimko thank you for the help here, I have cut a release! |
|
@wseaton Thank you very much for developing such a useful library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to statistics, Python 3.7's current usage share still exceeds 20%. Since sqloxide itself supports Python 3.7, we hope to ensure support for it when building wheels.