Add support for Java 9 multi release jars #61 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A property for library jar exclusions (libraryJarExclusion)
| } | ||
| } | ||
|
|
||
| private void addLibraryJar(ArrayList<String> args, ArrayList<File> libraryJars, File file) |
There was a problem hiding this comment.
In the method signature we could just use List instead of ArrayList
There was a problem hiding this comment.
Suggested change
| private void addLibraryJar(ArrayList<String> args, ArrayList<File> libraryJars, File file) | |
| private void addLibraryJar(List<String> args, List<File> libraryJars, File file) |
| args.add("-libraryjars"); | ||
| args.add(fileToString(file)); | ||
| if (libraryJarExclusion != null) { | ||
| args.add(libraryJarExclusion); |
There was a problem hiding this comment.
If I understood correctly, this exclusion string should be added immediately after the filename without any spaces between them. This would seem to add it as a separate argument for the command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61