fix: auto icons override default icons

[omerfardemir]

just removed return statement in line 35.

wxt/packages/auto-icons/src/index.ts

Line 35 in 31071bd

return wxt.logger.warn(

Manual Testing

1. have default icons in the public folder public/icon/*
2. install auto icons
3. add a icon to <src>/assets/icon.png
4. run npm run dev

This PR closes #1592

[netlify]

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	1146ac1
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/688aa6e6ae1b280008b4951b
😎 Deploy Preview	https://deploy-preview-1616--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Timeraa]

Could you add a test for this?

[omerfardemir]

I added tests and here is output:

✓ src/__test__/index.test.ts (9 tests) 23ms
   ✓ auto-icons module > options handling > should use default options when not provided 5ms
   ✓ auto-icons module > options handling > should merge custom options with defaults 1ms
   ✓ auto-icons module > error handling > should warn when disabled 4ms
   ✓ auto-icons module > error handling > should warn when base icon not found 1ms
   ✓ auto-icons module > manifest generation > should update manifest with icons 2ms
   ✓ auto-icons module > manifest generation > should warn when overwriting existing icons in manifest 1ms
   ✓ auto-icons module > icon generation > should generate icons with correct sizes 2ms
   ✓ auto-icons module > icon generation > should apply grayscale in development mode but not in production 1ms
   ✓ auto-icons module > public paths > should add icon paths to public paths 1ms

 Test Files  1 passed (1)
      Tests  9 passed (9)
   Start at  00:40:30
   Duration  630ms (transform 35ms, setup 0ms, collect 84ms, tests 23ms, environment 0ms, prepare 185ms)

[Timeraa]

Thank you, did I not add any tests to that module when I made it? Oopsies haha.

Looks all fine from me so @aklinker1 can merge when he approves of it

[aklinker1]

I'm alive! Been busy with some other life stuff. Should be back on GitHub and discord soon.

[Timeraa]

I'm alive! Been busy with some other life stuff. Should be back on GitHub and discord soon.

No worries everyone gets through things like that in life sometimes! I'm currently going through a lot of it as well

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (c8cd41a) to head (1146ac1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1616      +/-   ##
==========================================
+ Coverage   81.17%   81.20%   +0.03%     
==========================================
  Files         130      130              
  Lines        6649     6649              
  Branches     1091     1090       -1     
==========================================
+ Hits         5397     5399       +2     
+ Misses       1241     1239       -2     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pkg-pr-new]

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1616

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1616

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1616

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1616

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1616

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1616

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1616

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1616

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@1616

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1616

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1616

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1616

wxt

npm i https://pkg.pr.new/wxt@1616

commit: 93ef8ac