Skip to content

fix: exclude open_in_tab from options_ui for Safari #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rxliuli wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −2
Open

fix: exclude open_in_tab from options_ui for Safari #2311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a960c
fix: exclude `open_in_tab` from options_ui manifest for Safari
rxliuli Apr 27, 2026
cb2664d
fix: resolve type errors in options_ui Safari handling
rxliuli Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/wxt/src/core/utils/__tests__/manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,28 @@ describe('Manifest Utils', () => {

expect(actual.options_ui).toEqual(expected);
});

it('should exclude open_in_tab for safari', async () => {
setFakeWxt({
config: {
manifestVersion: 3,
browser: 'safari',
outDir,
},
});
const buildOutput = fakeBuildOutput();

const { manifest: actual } = await generateManifest(
[options],
buildOutput,
);

expect(actual.options_ui).toEqual({
chrome_style: true,
page: 'options.html',
});
expect(actual.options_ui?.open_in_tab).toBeUndefined();
});
});

describe('background', () => {
Expand Down
5 changes: 3 additions & 2 deletions packages/wxt/src/core/utils/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,9 @@ function addEntrypoints(
if (options) {
const page = getEntrypointBundlePath(options, wxt.config.outDir, '.html');
manifest.options_ui = {
open_in_tab: options.options.openInTab ?? false,
// @ts-expect-error: Not typed by @wxt-dev/browser, but supported by Firefox
...(wxt.config.browser !== 'safari' && {
open_in_tab: options.options.openInTab ?? false,
}),
browser_style:
wxt.config.browser === 'firefox'
? options.options.browserStyle
Expand Down