refactor: split env.go handlers into domain files#188
Merged
Conversation
pthapa1
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/userFlags/env.go(918 lines) into 6 focused handler files, each with co-located command factory and handler functionsenv_crud.go,env_list.go,env_edit.go,env_keys.go,env_recipients.go,env_sync.goenv_test.go(924 lines) into matching test files:env_crud_test.go,env_list_test.go,env_edit_test.gonewEnv*Cmd()factories toenv_rotate_key.goandenv_migrate.gosubcommands.gofrom 784 to 450 lines —newEnvCmd()is now a clean assembly listStdoutHeaderstopkg/utils/table.go(exported, reusable next toPrintTable)env.goentirely — shared constants moved to their respective consumer filesZero behavior changes. 88/88 tests pass.
mise checkall green.Part of epic #125.
Test plan
mise checkpasses (lint, vet, tests)hulak env set/get/delete/list/keys/editall work as beforehulak env import-key/export-keywork as beforehulak env add-recipient/remove-recipient/list-recipientswork as beforehulak env rotate/rotate-key/migratework as before