ocaml-evtchn: drop dependency on xenctrl, and use xenevtchn.h instead#21
Merged
edwintorok merged 2 commits intoxapi-project:mainfrom Oct 28, 2025
Merged
ocaml-evtchn: drop dependency on xenctrl, and use xenevtchn.h instead#21edwintorok merged 2 commits intoxapi-project:mainfrom
edwintorok merged 2 commits intoxapi-project:mainfrom
Conversation
Note that this is still not OCaml 5 compatible, we also need to fix that separately: it uses naked pointers. Closes xapi-project#20 Signed-off-by: Edwin Török <edwin.torok@citrix.com>
andyhhp
reviewed
Oct 28, 2025
last-genius
approved these changes
Oct 28, 2025
Member
Author
|
We should eventually update this (and the upstream ocaml-evtchn) to use the one from Xen instead, which seems to have some OCaml 5 fixes? Although I think there were some changes here compared to both versions. |
Signed-off-by: Edwin Török <edwin.torok@citrix.com>
andyhhp
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is still not OCaml 5 compatible, we also need to fix that separately: it uses naked pointers.
Closes #20