Draft
Conversation
kambala-decapitator
changed the title
Collaborator
|
I don't understand what's the point of mixing UIKit (the view controller that you have) and SwiftUI. Choose a single UI framework. |
Author
|
No worries at all - most of this was attempting to understand how to implement the feature. I'll update as soon as I can; before UI I want to work out how best to send the JSON-RPC request. There's actually no UI whatsoever that has been implemented yet. |
Collaborator
main app already has such code. Extract it into a (dynamic) framework and link it to both app and extension. |
Author
|
Yeah I was looking at the tcpJSONRPC class - will investigate and hopefully update this pull request again soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Share Extension and initial logic to check if url is from YouTube - call of JSONRPC API needs integration.
Description
These changes make the kodi remote app appear when sharing URLs. At the moment, choosing to share doesn't actually do anything. I imagine before merging a SwiftUI View will need to be made in order to choose between whether the use wants to queue or play the item immediately
Summary for release notes
Adds share extension for YouTube urls to kodi remote