Rework discovery timeout handling#1435
Merged
kambala-decapitator merged 2 commits intoxbmc:masterfrom Jan 12, 2026
Merged
Conversation
Do not show results after a discovery timeout. This could happen, if multiple servers were found, but the TCP port discovery for the selected host fails with timeout. In addition, choose better name for ivar and refactor updateUI to use switch-case and early return.
updateUI will not do anything if discoveryIsSearching = YES.
wutschel
force-pushed
the
fix_discovery_timeout
branch
from
599ba8d to
fd2a4ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not show results after a discovery timeout. This could happen, if multiple servers were found, but the TCP port discovery for the selected host fails with timeout. In addition, choose better name for an ivar and refactor
updateUIto use switch-case and early return.Summary for release notes
Bugfix: Do not show results after a TCP discovery timeout