Open
Conversation
The entire depends/common/iconv/ directory was copied from https://github.com/xbmc/inputstream.ffmpegdirect/tree/527a71baa23a81e79b7ee2b1a658e73b54339978/depends/common/iconv
✅ Safe to mergeNo breaking changes, hashes verified, limited impact scope. Version Diff
Changelog Highlights
Impact Assessment1 consuming file found in the codebase.
Patch Changes
|
Review Details
|
![kodiai[bot]](https://avatars.githubusercontent.com/in/2832814?s=60&v=4){kind=small}
oliver
added a commit
to oliver/repo-binary-addons
that referenced
this pull request
Apr 6, 2026
…18" branch) This is necessary for building the add-on under Debian Testing, until xbmc/audiodecoder.sacd#95 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entire depends/common/iconv/ directory was copied from https://github.com/xbmc/inputstream.ffmpegdirect/tree/527a71baa23a81e79b7ee2b1a658e73b54339978/depends/common/iconv
This PR fixes building this addon with GCC 15, e.g. under Debian Testing.
It compiles successfully, but I did not yet test whether the addon actually works.