Skip to content

Conversation

glehmann
Copy link
Member

@glehmann glehmann commented Jul 4, 2025

We can now uv sync in the dir, and export PATH=$PWD/.venv/bin:$PATH to use koji-build with its required dependency.

The package should also be publishable, allowing, in the future, to pipx install koji-utils to have koji-build and the other tools available in the shell.

Note that I had to move koji_build.py to a module directory. The root koji_build.py now prints a warning saying it's been moved, but we could also not print any warning.

@glehmann glehmann requested review from stormi and ydirson July 4, 2025 09:21
@glehmann glehmann marked this pull request as draft July 4, 2025 09:22
@glehmann glehmann force-pushed the gln/koji-build-script-rvln branch from 13a2b2e to 9a30b4e Compare July 4, 2025 09:29
@stormi
Copy link
Member

stormi commented Jul 17, 2025

Does this incur a change for current users of the koji_build.py script?

Copy link
Contributor

@ydirson ydirson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info in the commit message would be useful in a README, and maybe uvx can be suggested for install?

@glehmann
Copy link
Member Author

Does this incur a change for current users of the koji_build.py script?

Currently it only display a warning about the file location that has been changed. But that's not mandatory.

@@ -0,0 +1 @@
3.11.11
Copy link
Contributor

@psafont psafont Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this file? This version can't be enforced (my system doesn't provide it)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv uses it to pin the python version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this file? This version can't be enforced (my system doesn't provide it.

uv should install that exact version for you. That's not the case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I install tools using uv tool, I've never seen it installing python version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels strange, as https://docs.astral.sh/uv/guides/tools/ says uv tool run is the same as uvx, and

Tools are installed into temporary, isolated environments when using uvx.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the system python matches the version allowed in pyproject.toml, I don't see why it would be strange to use the system interpreter

@glehmann glehmann force-pushed the gln/koji-build-script-rvln branch 2 times, most recently from 0d39503 to 7427a6a Compare July 21, 2025 15:36
@glehmann glehmann marked this pull request as ready for review July 21, 2025 15:38
@glehmann glehmann requested review from ydirson and psafont July 21, 2025 15:38
@glehmann glehmann force-pushed the gln/koji-build-script-rvln branch 2 times, most recently from f9405d1 to 9ae3dc1 Compare August 1, 2025 20:59
@glehmann glehmann force-pushed the gln/koji-build-script-rvln branch from 9ae3dc1 to c16a69e Compare August 11, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants