Ensuring the xip extraction will work #167
Conversation
aln787
commented
Sep 14, 2016
aln787
commented
- Adding an alert if the os version is less than 10.11.5. Issue xcpretty#163
KrauseFx
left a comment
KrauseFx
left a comment
There was a problem hiding this comment.
Thanks for the pull request, I added some comments before it's ready
| File.symlink?(SYMLINK_PATH) ? SYMLINK_PATH : nil | ||
| end | ||
|
|
||
| def os_version_compatibility_issue?(version) |
There was a problem hiding this comment.
Could you add some comments here with context on why this is necessary?
There was a problem hiding this comment.
I will add a few comments describing the issue with<10.11.5 failing to extract the archive
There was a problem hiding this comment.
I added a comment. Let me know If you would like me to rebase and submit as a single commit.
lib/xcode/install/install.rb
Outdated
| super | ||
|
|
||
| help! 'A VERSION argument is required.' unless @version | ||
| fail Informative, 'An OS X version >10.11.4 is required for xcode 8.' if @installer.os_version_compatibility_issue?(@version) |
aln787
left a comment
aln787
left a comment
There was a problem hiding this comment.
I made the requested changes. Let me know If you would like me to rebase and submit as a single commit.
| File.symlink?(SYMLINK_PATH) ? SYMLINK_PATH : nil | ||
| end | ||
|
|
||
| def os_version_compatibility_issue?(version) |
There was a problem hiding this comment.
I added a comment. Let me know If you would like me to rebase and submit as a single commit.
2 participants
