Open
Conversation
In most cases, the strings are treated as null terminated elsewhere so limiting to sizeof()-1 is correct. In the case of req.ifr_name, the kernel adds null termination if the name isn't already. sun_path doesn't need to be null terminated, so this does limit the path to one less than maximum.
This caused a warning with gcc9
In the error path this string is used to indicate the caller
gcc9 issues a warning about possible overlapping areas
Fedora 33 starts correctly resolving the ports to service names, so disable this with "-nn" for now.
This only affects the testing code. I believe this is related to -fno-common becoming the default for gcc-10. The test code just needed a bit of cleanup to stop duplicating symbols that are part of libpluto.
A few tests segfault on ubuntu 20.04 due to a glibc/efence incompatibility when calling getaddrinfo(). Disable efence for these tests to avoid the issue.
…ept for RSA key values
…/right clients if there are no clients
…skip checking it if was not set
…d in. Also easier to maintain
…te in new test case
…in item.label being in different place for plutoctrl_cbor.c than for compiled QCBOR library in libwhack.
mcr
force-pushed
the
t16176-integrate-whackread-into-pluto
branch
from
8a29f67 to
20fd1e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should fix the --initiate problem, as well as a few other minor problems.